Test each change once, not on both its push and its pull request #15

Merged
jeff merged 1 commit from ci-once into main 2026-10-14 02:55:17 -05:00
Owner

test.yaml ran on every push and every pull_request, so a branch with an open pull request was tested twice on two runners. That includes every submission winget-bot opens.

  • Pushes now trigger the workflow only on main. The main run also publishes, so it stays.
  • Every other change is tested through its pull request. That run produces test / test (pull_request), the check branch protection requires, so the merge rule is unchanged.
  • A branch pushed without a pull request isn't tested until one is opened. Nothing reaches main without a pull request, so nothing goes unchecked.
  • The --changed-since logic already handles both events: the pull request's base on pull_request, and the replaced commit on main.
  • CONTRIBUTING now says when CI runs.

This also reverses what I recommended in the design for #4 (Q18), where I said the duplicate run was worth accepting.

This pull request should run once: test / test (pull_request) only.

🤖 Generated with Claude Code

https://claude.ai/code/session_01D31MsLkM9DkCauP1EB2zgw

`test.yaml` ran on every `push` and every `pull_request`, so a branch with an open pull request was tested twice on two runners. That includes every submission `winget-bot` opens. - Pushes now trigger the workflow only on `main`. The `main` run also publishes, so it stays. - Every other change is tested through its pull request. That run produces `test / test (pull_request)`, the check branch protection requires, so the merge rule is unchanged. - A branch pushed without a pull request isn't tested until one is opened. Nothing reaches `main` without a pull request, so nothing goes unchecked. - The `--changed-since` logic already handles both events: the pull request's base on `pull_request`, and the replaced commit on `main`. - CONTRIBUTING now says when CI runs. This also reverses what I recommended in the design for #4 (Q18), where I said the duplicate run was worth accepting. This pull request should run once: `test / test (pull_request)` only. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01D31MsLkM9DkCauP1EB2zgw
test each change once, not on both its push and its pull request
All checks were successful
test / test (pull_request) Successful in 1m40s
test / publish (pull_request) Has been skipped
fff25ce375
A branch push and its pull request ran the same tests on two runners.
Now pushes are tested only on main, where the run also publishes, and
everything else through its pull request, whose check is the one branch
protection requires.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01D31MsLkM9DkCauP1EB2zgw
jeff scheduled this pull request to auto merge when all checks succeed 2026-10-14 02:54:36 -05:00
jeff merged commit 84ffb35fd9 into main 2026-10-14 02:55:17 -05:00
jeff deleted branch ci-once 2026-10-14 02:55:17 -05:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
jeff/winget-pkgs!15
No description provided.