Read an MSI's ProductCode in new-version rather than requiring --product-code #24

New issue

Closed

opened 2026-10-14 11:41:45 -05:00 by jeff · 0 comments

jeff commented

2026-10-14 11:41:45 -05:00

Owner

new-version requires --product-code for every installer that has a ProductCode, so each program's release workflow has to read it out of its own MSI and pass it through winget-submit's product-codes input. new-version already downloads the installer to hash it, and could read the code from it with msiinfo instead, keeping --product-code as an override. Making the flag optional is an addition, which ADR 0004 allows.

Follows from the new-package work, which reads the codes from the MSI the same way.

`new-version` requires `--product-code` for every installer that has a `ProductCode`, so each program's release workflow has to read it out of its own MSI and pass it through winget-submit's `product-codes` input. `new-version` already downloads the installer to hash it, and could read the code from it with `msiinfo` instead, keeping `--product-code` as an override. Making the flag optional is an addition, which ADR 0004 allows. Follows from the `new-package` work, which reads the codes from the MSI the same way.

jeff referenced this issue from jeff/winget-submit

2026-10-14 11:41:50 -05:00

Make product-codes an override once new-version reads the MSI #8

jeff added a new dependency

2026-10-14 11:41:54 -05:00

jeff/winget-submit#8 - Make product-codes an override once new-version reads the MSI

jeff referenced this issue

2026-10-14 11:45:56 -05:00

Write a package's first version with wingetsource new-package #25

jeff referenced this issue from a pull request that will close it,

2026-10-14 11:58:42 -05:00

Read an MSI's ProductCode in new-version #26