Fragments, references and several WiX sources #8

New issue

Closed

opened 2026-10-14 01:26:54 -05:00 by jeff · 1 comment

jeff commented

2026-10-14 01:26:54 -05:00

Owner

Parent

Part of #1

What to build

Fragment, DirectoryRef, ComponentRef, ComponentGroup, ComponentGroupRef and FeatureRef, with several WiX sources given on one command line and compiled into one WiX document. Referencing a fragment pulls it in. An Id used twice for the same kind of element is an error naming both locations; a reference to an Id that does not exist is an error naming it.

Acceptance criteria

Seam 1 tests: a product split across three WiX sources builds the same installer database as the same product in one.
Seam 1 tests: a duplicate Id gives a diagnostic naming both locations; an unresolved reference gives one naming the missing Id and where it was referenced.
Seam 1 test: a fragment nothing references contributes nothing.
VM test: the multi-source fixture's tables match the reference implementation's with generated columns masked, and it installs under Wine.

## Parent Part of #1 ## What to build `Fragment`, `DirectoryRef`, `ComponentRef`, `ComponentGroup`, `ComponentGroupRef` and `FeatureRef`, with several WiX sources given on one command line and compiled into one WiX document. Referencing a fragment pulls it in. An `Id` used twice for the same kind of element is an error naming both locations; a reference to an `Id` that does not exist is an error naming it. ## Acceptance criteria - [ ] Seam 1 tests: a product split across three WiX sources builds the same installer database as the same product in one. - [ ] Seam 1 tests: a duplicate `Id` gives a diagnostic naming both locations; an unresolved reference gives one naming the missing `Id` and where it was referenced. - [ ] Seam 1 test: a fragment nothing references contributes nothing. - [ ] VM test: the multi-source fixture's tables match the reference implementation's with generated columns masked, and it installs under Wine.

jeff added the

ready-for-agent

label

2026-10-14 01:26:54 -05:00

jeff added a new dependency

2026-10-14 01:27:06 -05:00

#3 Files in an embedded, uncompressed cabinet

jeff added a new dependency

2026-10-14 01:27:07 -05:00

#16 Fuzz targets for the preprocessor and the compiler

jeff self-assigned this

2026-10-14 03:54:11 -05:00

jeff referenced this issue from a commit

2026-10-14 04:15:45 -05:00

Link fragments, references and several WiX sources (#8)

jeff commented

2026-10-14 04:44:44 -05:00

Author

Owner

Done in 30c8a57; CI run 8 is green.

The model: each <Product> and <Fragment> is a section. Linking starts from the one product and pulls in every section reachable through DirectoryRef, ComponentRef, ComponentGroupRef, FeatureRef, PropertyRef, Component/@Directory and ComponentGroup/@Directory. Component groups, including groups within groups, expand into the features that name them.
Seam 1:
- three sources build the same tables as one source holding the same sections;
- an unreferenced fragment contributes nothing;
- a duplicate Id across sources names both places;
- an unresolved reference names the Id and where it was referred to;
- there must be exactly one <Product>.
End to end: the three-source split fixture matches wixl's tables and installs under Wine on x86 and x64.

Where the reference implementation departs from WiX:

It has no <FeatureRef> under <Product>.
It links every fragment, whether or not anything refers to it.

The comparison fixture stays off both.

Done in 30c8a57; CI run 8 is green. - **The model:** each `<Product>` and `<Fragment>` is a section. Linking starts from the one product and pulls in every section reachable through `DirectoryRef`, `ComponentRef`, `ComponentGroupRef`, `FeatureRef`, `PropertyRef`, `Component/@Directory` and `ComponentGroup/@Directory`. Component groups, including groups within groups, expand into the features that name them. - **Seam 1:** - three sources build the same tables as one source holding the same sections; - an unreferenced fragment contributes nothing; - a duplicate Id across sources names both places; - an unresolved reference names the Id and where it was referred to; - there must be exactly one `<Product>`. - **End to end:** the three-source `split` fixture matches wixl's tables and installs under Wine on x86 and x64. Where the reference implementation departs from WiX: - It has no `<FeatureRef>` under `<Product>`. - It links every fragment, whether or not anything refers to it. The comparison fixture stays off both.

jeff closed this issue

2026-10-14 04:44:44 -05:00