jeff/winget-submit
Watch
1
0
Fork
You've already forked winget-submit
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Pass product codes through to new-version #6

New issue
Closed
opened 2026-10-14 03:10:18 -05:00 by jeff · 0 comments
jeff commented 2026-10-14 03:10:18 -05:00
Owner
Copy link

Part of jeff/winget-pkgs#5
Blocked by: jeff/winget-pkgs#18

Add a product-codes input, one <architecture> <code> per line like
installers, passed to wingetsource new-version as one --product-code ARCHITECTURE=CODE each. Optional: a package whose installers have no
ProductCode passes nothing, as today.

For harrier, whose MSI gets a new ProductCode every release: its winget
job reads the code from the built MSI (msiinfo) and passes it here.

  • Parse it with the same rules as installers (blank lines ignored, two
    fields per line, no repeated architecture), with tests.
  • README: the input in the table, and a note that a wix/msi package needs
    it once jeff/winget-pkgs#18 makes new-version refuse a stale code.
  • Bump the commit harrier and clipwatch pin only where they need it; clipwatch
    does not.
Part of jeff/winget-pkgs#5 Blocked by: jeff/winget-pkgs#18 Add a `product-codes` input, one `<architecture> <code>` per line like `installers`, passed to `wingetsource new-version` as one `--product-code ARCHITECTURE=CODE` each. Optional: a package whose installers have no `ProductCode` passes nothing, as today. For harrier, whose MSI gets a new `ProductCode` every release: its `winget` job reads the code from the built MSI (`msiinfo`) and passes it here. - Parse it with the same rules as `installers` (blank lines ignored, two fields per line, no repeated architecture), with tests. - README: the input in the table, and a note that a `wix`/`msi` package needs it once jeff/winget-pkgs#18 makes `new-version` refuse a stale code. - Bump the commit harrier and clipwatch pin only where they need it; clipwatch does not.
jeff closed this issue 2026-10-14 03:33:53 -05:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fixed-submitter
No results found.
Labels
Clear labels   
needs-info
Waiting on reporter for more information

  
needs-triage
Maintainer needs to evaluate this issue

  
ready-for-agent
Fully specified, ready for an AFK agent

  
ready-for-human
Requires human implementation

  
wontfix
Will not be actioned

No labels
needs-info
needs-triage
ready-for-agent
ready-for-human
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#5 Submit new versions from harrier's release workflow
jeff/winget-pkgs
Depends on
#18 new-version: update an MSI installer's ProductCode, and refuse to copy a stale one
jeff/winget-pkgs
Reference
jeff/winget-submit#6
No description provided.